this is an improvement on how the convergence chart is plotted #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now rather than using when the submission was last updated, we track the first time any fields that are vote shares were updated and use that instead. see nditech/apollo-issues#32
|
LGTM. As I understand it, on every save operation, the voting timestamp is added if it doesn't already exist and a vote share is updated, and it is then used for the results data summary in place of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now rather than using when the submission was last updated, we track the first time any fields that are vote shares were updated and use that instead.
see nditech/apollo-issues#32