Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform workflow improvements #202

Open
1 of 5 tasks
Tracked by #219
itegulov opened this issue Jul 20, 2023 · 0 comments · Fixed by #208
Open
1 of 5 tasks
Tracked by #219

Terraform workflow improvements #202

itegulov opened this issue Jul 20, 2023 · 0 comments · Fixed by #208
Assignees
Labels
Emerging Tech Emerging Tech flying formation at Pagoda Near BOS NEAR BOS team at Pagoda

Comments

@itegulov
Copy link
Contributor

itegulov commented Jul 20, 2023

Having an environment deployed per PR is wasteful as many of them don't need it. Let's figure out a way to do this conditionally; so far I am considering the following options:

  1. Wait until the PR author posts a comment, e.g. terraform deploy. See https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#issue_comment
  2. Only do this for PRs that contain [deploy] in the title. For example, feat[deploy]: new ui will deploy enviornment, while fix: README won't
  3. Make deploys purely manual. The author will have to go to the Github Action tab, press a button there and enter the PR number.

Tasks

Preview Give feedback
@itegulov itegulov linked a pull request Jul 24, 2023 that will close this issue
@itegulov itegulov reopened this Jul 24, 2023
@itegulov itegulov self-assigned this Jul 26, 2023
@trechriron trechriron added Near BOS NEAR BOS team at Pagoda Emerging Tech Emerging Tech flying formation at Pagoda labels Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Emerging Tech Emerging Tech flying formation at Pagoda Near BOS NEAR BOS team at Pagoda
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

2 participants