-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEAR Lake Indexer does not work on macos #393
Comments
question: https://github.com/orgs/near/packages/container/near-lake-indexer/147379646?tag=e6519c922435f3d18b5f2ddac5d1ec171ef4dd6b how is the tag picked? We currently in code intentionally force to use a specific tag of the indexer (same for the os-relayer), I guess we'd want to stick with that. If so, I could build a macos image at the same commit you built the above one from, and push it. We can configure same tag to contain multiple images for different architectures, and when I do docker pull, it will pull the compatible one, example: https://github.com/orgs/near/packages/container/near-lake-indexer/152859204?tag=toy Or I could also build a linux version and a macOS image from latest code, put them both under the tag of latest, and both under the tag of commit_hash. But then a PR is needed and folks need to pull the new docker image (edited) btw, using the docker image of indexer built locally on mac machine, all tests are running fine |
This is how to enable automatically pulling the image compatible with your local system from the same tag: doc |
This is the commit hash of the indexer at the moment when I built it: near/near-lake-indexer@e6519c9
Yes, that's awesome and exactly what I was looking for!
Yeah I would say just build latest and we can update the tag in #392 to make that PR actually fix tests on macos. Also, I don't actually think you need to pull the docker images manually given that you have logged into Github Container Registry already. The tests will just pull the image automatically so I wouldn't worry too much about other people needing to pull the image
👍 |
ghcr.io/near/near-lake-indexer:18ef24922fd7b5b8985ea793fdf7a939e57216ba added with both images and also marked as latest |
Description
Running NEAR Lake Indexer results into the following errors:
The most likely reason is that I built the original image on an x86 Linux machine and we need a separate macos ARM-based image. Dockerfile was added in this PR.
Proposed steps to resolve this:
latest-aarch64
taglatest
tag conditionally choose which image to pull depending on your host system. I know that Docker Hub can do this, not sure about Github Container Registry.The text was updated successfully, but these errors were encountered: