feat: add terraform module for partners #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volovyks
approved these changes
Sep 19, 2023
ChaoticTempest
approved these changes
Sep 20, 2023
|
|
||
| credentials_source = service_account.Credentials.from_service_account_file( | ||
| '../source-service-keys.json') | ||
| client_source = datastore.Client(project="pagoda-discovery-platform-dev", credentials=credentials_source) |
There was a problem hiding this comment.
I'm guessing parameters like project="pagoda-discovery-platform-dev" are just here for reference when the migration for Satori is done
There was a problem hiding this comment.
yeah, I will replace these placeholders with actual values before running the script, just not sure what their projects are called yet
| required_providers { | ||
| google = { | ||
| source = "hashicorp/google" | ||
| version = "4.66.0" |
There was a problem hiding this comment.
any reason why we're using an older version instead of the same one in develop: 4.73.0?
There was a problem hiding this comment.
I am just using what is currently in main, we bumped the version in develop some time back.
volovyks
added a commit
that referenced
this pull request
Sep 21, 2023
* feat: terraform configuration (#170) * feat: add terraform module for partners (#294) * redundant variables deleted * terraform fmt * redundant parameters deleted * lookup_url deleted from setup * fmt * redundant dep deleted * duplicated service-account-datastore-user deleted * unused terraform value firebase_audience_id deleted * terraform fmt --------- Co-authored-by: Daniyar Itegulov <ditegulov@gmail.com> Co-authored-by: DavidM-D <dmillardurrant@gmail.com> Co-authored-by: Phuong Nguyen <ChaoticTempest@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: this branch is targeting
mainThis PR adds a dedicated terraform module that our partners will be using. It is tailored to create a single signer node and assumes that they have a docker image on their machine (I have a .tar file that I can share with people who don't have an x86 machine, other people can build their own image if they want).
This also adds a migration script that I plan to use to migrate Satori to NEAR Tasks. Will delete it from the repo after we are done, but just want to get another pair of eyes on just in case.