feat: metrics for node up and signing latency #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Feature Environment (dev-490)Terraform Initialization ⚙️
|
ppca
changed the title
ChaoticTempest
approved these changes
Mar 14, 2024
| @@ -120,7 +121,11 @@ async fn handle_block( | |||
| epsilon, | |||
| delta, | |||
| entropy, | |||
| time_added: Instant::now(), | |||
There was a problem hiding this comment.
nit: how about we keep it consistent with timestamp everywhere else since timestamp is usually associated to when something is created anyways
| IntGauge, IntGaugeVec, Opts, Result, TextEncoder, | ||
| }; | ||
|
|
||
| pub(crate) static NODE_RUNNING: Lazy<IntGaugeVec> = Lazy::new(|| { |
There was a problem hiding this comment.
is it by convention to create Lazy values for doing metrics in prometheus? If not, we should have it be initialized from one place when the node starts up. It's hard to configure these things down the line since they're globals, but it's not something we have to do right now since there are more important things. If that's the case, then let's also create a ticket to revisit later
volovyks
approved these changes
Mar 14, 2024
Terraform Feature Environment Destroy (dev-490)Terraform Initialization ⚙️
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whether node is up, sign request count, sign success, sign latency