Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up types and introduce runtime checks #457

Open
vgrichina opened this issue Nov 20, 2020 · 0 comments
Open

Clean-up types and introduce runtime checks #457

vgrichina opened this issue Nov 20, 2020 · 0 comments

Comments

@vgrichina
Copy link
Contributor

vgrichina commented Nov 20, 2020

We often don't have runtime checks for types "enforced" by TypeScript typings, see e.g. https://github.com/near/near-api-js/pull/452/files/777229d6bfa9b27ee21f5409dd74a686645786d0#r527117530

We need to introduce easy way to do such checks at scale.

There is also somewhat related issue of types not being correct in the first place. E.g. most places where BN is declared as type is actually accepting anything that can be converted to BN (i.e. BN, string and even small enough number). We should make this explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: NEW❗
Development

No branches or pull requests

1 participant