Implement timeout handling at sendJsonRpc level #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change basically moves existing exponential retry logic from Account deeper. Also handling `query has timed out` popping up on some endpoints under load.
volovyks
reviewed
Feb 23, 2021
src/providers/json-rpc-provider.ts
Outdated
| } catch (error) { | ||
| // TODO: Somehow getting still: | ||
| // Error: send_tx_commit has timed out. | ||
| // TODO: Check if nearcore still sends this or some other messages for timeout |
There was a problem hiding this comment.
@vgrichina have you checked this? probably it should be done before the merge
There was a problem hiding this comment.
Removed these TODOs as no longer relevant, TimeoutError thrown by us deeper in the call stack
This was referenced Mar 15, 2021
build(deps): bump near-api-js from 0.35.0 to 0.38.0 in /templates/vue
ramonbrugman/create-near-app#3
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change basically moves existing exponential retry logic from Account deeper.
Also handling
query has timed outpopping up on some endpoints under load.This fixes multiples problems which are both reported on users and popping up on Sentry (once nearcore RPC is failing under load):
https://sentry.io/organizations/near-protocol/issues/1953747896/?project=5396205&query=is%3Aunresolved&sort=freq&statsPeriod=14d
https://sentry.io/organizations/near-protocol/issues/2124349518/?project=5396205&query=is%3Aunresolved&sort=freq&statsPeriod=14d
https://sentry.io/organizations/near-protocol/issues/1927563464/?project=5396205&query=is%3Aunresolved&sort=freq&statsPeriod=14d
https://sentry.io/organizations/near-protocol/issues/2112717975/?project=5396205&query=is%3Aunresolved&sort=freq&statsPeriod=14d
https://sentry.io/organizations/near-protocol/issues/2125663232/?project=5396205&query=is%3Aunresolved&sort=freq&statsPeriod=14d