Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong error message when trying to send all your tokens #583

Closed
bowenwang1996 opened this issue May 15, 2020 · 7 comments
Closed

Wrong error message when trying to send all your tokens #583

bowenwang1996 opened this issue May 15, 2020 · 7 comments
Assignees
Labels
Bug Something is not working as it should

Comments

@bowenwang1996
Copy link
Contributor

Problem
If I try to send all my tokens to some other account, it will silently fail and in the console it shows

Error: {}
    at Object.u [as parseRpcError] (rpc_errors.js:25)
    at i.sendJsonRpc (json-rpc-provider.js:60)
    at async f.signAndSendTransaction (account.js:75)

Expected Behavior
Report the real error to users (LackBalance).

Steps to reproduce

  1. Go to wallet.betanet.near.org and register an account.
  2. Try sending all the tokens to some other existing account.
@bowenwang1996 bowenwang1996 added the Bug Something is not working as it should label May 15, 2020
@marcinbodnar marcinbodnar self-assigned this May 20, 2020
@marcinbodnar
Copy link
Contributor

@vgrichina @kcole16 First of all, why sending all fail?

@kcole16
Copy link
Contributor

kcole16 commented May 26, 2020

This actually should be fixed by this: #534 since we'll prevent user from sending their entire balance.

Basically, this error is due to user trying to remove their state stake (minimum balance) without deleting their account, which is a requirement to do so.

@marcinbodnar
Copy link
Contributor

Also, I can't find the locked balance PR anymore. Did we remove it?

It's here: #534

@kcole16
Copy link
Contributor

kcole16 commented May 26, 2020

Right, realized that after posting my message!

@marcinbodnar
Copy link
Contributor

marcinbodnar commented May 26, 2020

Basically, this error is due to user trying to remove their state stake (minimum balance) without deleting their account, which is a requirement to do so.

But it's already handled with #534 changes. Right? User is available to send his available balance only.

@marcinbodnar
Copy link
Contributor

@kcole16 @vgrichina Additionally, locally and on testnet we receive Timeout error so I'm not sure how can we handle it?

@kcole16
Copy link
Contributor

kcole16 commented May 28, 2020

Closed by #534

@kcole16 kcole16 closed this as completed May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as it should
Projects
None yet
Development

No branches or pull requests

3 participants