Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider chunk endorsements orphan pool #10557

Closed
Tracked by #46
Longarithm opened this issue Feb 2, 2024 · 2 comments
Closed
Tracked by #46

Consider chunk endorsements orphan pool #10557

Longarithm opened this issue Feb 2, 2024 · 2 comments
Labels
A-stateless-validation Area: stateless validation

Comments

@Longarithm
Copy link
Member

Longarithm commented Feb 2, 2024

If chunk endorsements is received before chunk, node will reject it because get_chunk is called on the way: https://near.zulipchat.com/#narrow/stream/407237-pagoda.2Fcore.2Fstateless-validation/topic/Receiving.20chunk.20endorsement.20before.20chunk.3F/near/419017966
The proper solution could be to orphan these endorsements until chunk is received.

It can be easier to store these if we endorse smth like a triple (prev_block_hash, shard_id, chunk_hash). Only one endorsement per chunk validator could be received and temporarily stored then.

However, local testing check has shown zero failures of that kind: https://near.zulipchat.com/#narrow/stream/407237-pagoda.2Fcore.2Fstateless-validation/topic/Handling.20orphan.20state.20witness/near/419184284

@Longarithm
Copy link
Member Author

May be needed - because it caused #10560

@Longarithm
Copy link
Member Author

The fix #10568 may be enough for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-stateless-validation Area: stateless validation
Projects
None yet
Development

No branches or pull requests

1 participant