Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using higher-performance SSD. Launch new IO fees #4461

Closed
MaksymZavershynskyi opened this issue Jul 6, 2021 · 9 comments
Closed
Assignees
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-contract-runtime Team: issues relevant to the contract runtime team

Comments

@MaksymZavershynskyi
Copy link
Contributor

MaksymZavershynskyi commented Jul 6, 2021

We have re-calculated IO costs and we discovered that they are more expensive than we thought before.

We should consider using higher-performance SSD to match the state of art on other blockchains.

Regardless of whether we switch our hardware requirement to higher-performance SSD or not we should update our protocol to use the new fees.

CC @janewang

@MaksymZavershynskyi MaksymZavershynskyi added T-node Team: issues relevant to the node experience team T-contract-runtime Team: issues relevant to the contract runtime team labels Jul 6, 2021
@vans163
Copy link

vans163 commented Jul 6, 2021

NVMEs cost as much as SSDs these days (unless you need really high density 4TB+) and have almost 10x more IOPS.

The costs should also not be based off AWS / Public Clouds, but off running normal dedicated servers / computers and regular IP transit (IXPs for example but this is too low a cost).

The cost for someone who has a 1gbps line to run a small node (like 4-8 core proc, 16G ram, 2tb NVME) is much less than running the same thing on AWS, mostly due to the 1000x markup bandwith costs clouds charge (compared to bandwith prices at a IXP).

@janewang janewang added C-enhancement Category: An issue proposing an enhancement or a PR with one. and removed T-node Team: issues relevant to the node experience team labels Jul 6, 2021
@bowenwang1996
Copy link
Collaborator

I believe we use "persistent SSD" on gcloud for benchmarks. They are likely much slower than local SSDs. We should potentially try that.

@vans163
Copy link

vans163 commented Jul 7, 2021

I believe we use "persistent SSD" on gcloud for benchmarks. They are likely much slower than local SSDs. We should potentially try that.

Can these benchmarks be done on metal OVH/Hetzner/Packet servers instead of virtualized cloud servers that have degraded unmeasurable performance? (impossible to predict how over provisioned the metal running the virtual server is during the benchmark)

@bowenwang1996
Copy link
Collaborator

Can these benchmarks be done on metal OVH/Hetzner/Packet servers instead of virtualized cloud servers that have degraded unmeasurable performance? (impossible to predict how over provisioned the metal running the virtual server is during the benchmark)

I believe quite a few validators still use cloud providers to run nodes. We'd like to make sure that would be still feasible

@stale
Copy link

stale bot commented Oct 5, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Oct 5, 2021
@stale
Copy link

stale bot commented Jan 4, 2022

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Jan 4, 2022
@bowenwang1996 bowenwang1996 removed their assignment Jan 7, 2022
@stale
Copy link

stale bot commented Apr 7, 2022

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Apr 7, 2022
@akhi3030 akhi3030 removed the S-stale label Jul 8, 2022
@matklad
Copy link
Contributor

matklad commented Aug 18, 2022

@jakmeier I think the status quo changed significantly since we created this issue. Do you think we should close it?

@jakmeier
Copy link
Contributor

I think closing is the right decision here.

But for context, let me mention the two big efforts that are currently ongoing to address the underlying concern here.

  1. Flat storage is supposed to reduce IO costs significantly AND make it much more predictable. It might also lead to a change in what parameters we use to charge IO costs. Therefore, we postpone fixing costs until that is implemented. (Flat storage MVP #7327)
  2. IO costs are currently the highest for archival nodes, which fall behind anytime there is lots of IO load. Cold storage implementation should help with that, as it will probably change what SSDs validators are using. And it changes what we could feasibly asked them to use. Thus, making any decision on current data is probably misguided.

With these two efforts in mind, I think we can close this old issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-contract-runtime Team: issues relevant to the contract runtime team
Projects
None yet
Development

No branches or pull requests

7 participants