Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle large Ropsten reorgs #329

Open
1 of 5 tasks
MaksymZavershynskyi opened this issue Aug 28, 2020 · 1 comment
Open
1 of 5 tasks

Handle large Ropsten reorgs #329

MaksymZavershynskyi opened this issue Aug 28, 2020 · 1 comment
Assignees

Comments

@MaksymZavershynskyi
Copy link
Contributor

MaksymZavershynskyi commented Aug 28, 2020

Background

Unfortunately, Ropsten sometimes undergoes huge re-orgs, specifically between 2020-08-26 9:54:22 PDT and 2020-08-25 16:23:30 PDT it re-orged 16k blocks. When this happens the following things happen:

Solution

To address this problem we need to do the following;

  • Indicate clearly in the documentation that it is not advised to use websockets for Ethereum node URLs;
  • Examine our code base and make sure we are not using websocket-specific features, like subscriptions to events;
    _threshold` configurable parameters that can be passed through a command line;
  • In the documentation that explains how to setup (will be introduced with Update the instructions in README.md to account for the split #326) explain that for Ropsten finalized_gc_threshold and hashes_gc_threshold should be set to 50k each;
  • Compute the amount of NEAR tokens we need to stake for EthOnNearClient to be able to handle finalized_gc_threshold=50k. Make sure we initialize EthOnNearClient with at least this number of tokens using near-client-init-balance parameter
  • Make finalized_gc_threshold and `hashes_gc
  • Add a parameter to init-near-contracts command that allows to initialize the client using the block from far in the past, because the current block might be easily revertable; link
@alexauroradev alexauroradev changed the title [Epic] Handle large Ropsten reorgs Handle large Ropsten reorgs Feb 4, 2021
@alexauroradev alexauroradev assigned mfornet and unassigned Kouprin Feb 4, 2021
@mfornet
Copy link
Contributor

mfornet commented Feb 8, 2021

Add a parameter to init-near-contracts command that allows to initialize the client using the block from far in the past, because the current block might be easily revertable;

If the current block is reverted, then client code is erased, so this doesn't solve the problem of block begin reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants