Skip to content
This repository has been archived by the owner on Oct 20, 2020. It is now read-only.

[Usability] Extract confirmations into connectors #3

Open
MaksymZavershynskyi opened this issue Aug 27, 2020 · 1 comment
Open

[Usability] Extract confirmations into connectors #3

MaksymZavershynskyi opened this issue Aug 27, 2020 · 1 comment
Assignees
Labels

Comments

@MaksymZavershynskyi
Copy link

Currently EthOnNearClient decides what is the number of confirmations until the header is considered to be confirmed. However, EthOnNearClient does not need to decide, and instead "connector" contract, e.g. MintableFungibleToken can decide for itself. It is actually, preferable, since different applications/tokens might want to have different confirmation thresholds. In case of a generic token connector https://github.com/near/rainbow-token-connector we can do either of the following:

  • Different instances of MintableFungibleToken deployed by the factory will have different num of confirmations;
  • All instances of MintableFungibleToken deployed by the factory will have the same num of confirmations.

This suggestion will change contract API and therefore it is preferable to do soon.

Assigning to @abacabadabacaba . @abacabadabacaba if you are not comfortable with this task yet, please re-assign to @ailisp

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants