feat: Come up with a standard to pass configuration to the deployed application #115
Conversation
src/services/k8s/knative.go
Outdated
| envVarList, err := loadEnvFile(envFile) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| serviceManifest.Spec.Template.Spec.Containers[0].Env = append(serviceManifest.Spec.Template.Spec.Containers[0].Env, envVarList...) | ||
|
|
There was a problem hiding this comment.
I think it could be beneficial to move this in the loadManifest function, by doing this you could also test this better by calling loadManifest with different inputs and testing the result manifest structure.
There was a problem hiding this comment.
moved to load manifest function.
in terms of testing I took out couple of cases that were checking load env file functionality & added sample env file as attribute to loadmanifest test case.
src/services/k8s/knative.go
Outdated
| return nil, fmt.Errorf("Error loading %v file: %v", envFile, err) | ||
| } | ||
| } else { | ||
| log.Info(fmt.Sprintf("Environment variables file %s found! Loading..", envFile)) |
There was a problem hiding this comment.
| log.Info(fmt.Sprintf("Environment variables file %s found! Loading..", envFile)) | |
| log.Infof("Environment variables file %s found! Loading..", envFile) |
There was a problem hiding this comment.
I had checked on their page for Infof and couldn't find anything related.. And then they had that for formatting messages with log.Info, that is why I went with it. Since Infof is working, switching to that one..
There was a problem hiding this comment.
That's interesting, should we contribute back to their repo and add the Infof?
Closes #104