Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide an option to deploy private services #132

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

zaremba-tomasz
Copy link
Contributor

@zaremba-tomasz zaremba-tomasz commented Oct 16, 2023

TODO:

  • flag value is not loaded properly from the persisted config file
  • flag location might be something worth discussing
  • compilation issue after rebase on latest main

Testing

Should output the knative manifest without labels

go run main.go deploy --dry-run

Should output the knative manifest with a labels with value cluster-local

go run main.go deploy --dry-run --private

Similarly you could generate the config with and run deploy to get a similar output:

go run mian.go init config --private --persist
go run main.go deploy --dry-run

@LucaLanziani LucaLanziani force-pushed the feat/cluster-local-service-by-default branch from ee674fa to c016d09 Compare October 18, 2023 13:20
@LucaLanziani LucaLanziani marked this pull request as ready for review October 18, 2023 13:20
@LucaLanziani LucaLanziani force-pushed the feat/cluster-local-service-by-default branch from c016d09 to e797a25 Compare October 18, 2023 14:38
@LucaLanziani LucaLanziani changed the title feat: knative service cluster-local by default feat: provide an option to deploy private services Oct 18, 2023
@LucaLanziani LucaLanziani merged commit 9528449 into main Oct 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants