Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: post application url and commit hash as a PR comment after every deploy #148

Merged
merged 30 commits into from
Nov 21, 2023
Merged

feat: post application url and commit hash as a PR comment after every deploy #148

merged 30 commits into from
Nov 21, 2023

Conversation

mablanco
Copy link
Contributor

See #127

@mablanco mablanco linked an issue Nov 16, 2023 that may be closed by this pull request
Post application url and commit hash as a PR comment after every deploy #127
Closed
@mablanco mablanco mentioned this pull request Nov 16, 2023
Closed
@mablanco mablanco self-assigned this Nov 17, 2023
@mablanco mablanco marked this pull request as ready for review November 20, 2023 12:16
@dublx
Copy link

dublx commented Nov 20, 2023

The code from this PR is looking good(but I have very rusty Golang from years ago).
This is a nice feature and the implementation seems to be spot on.

@mablanco mablanco requested a review from dublx November 20, 2023 13:18
@mablanco mablanco merged commit 79d5a2e into main Nov 21, 2023
2 checks passed
@github-actions github-actions bot mentioned this pull request Nov 21, 2023
Merged
@mablanco mablanco deleted the feat/post-comment-to-gitlab-pr branch November 21, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dublx dublx dublx approved these changes

@LucaLanziani LucaLanziani Awaiting requested review from LucaLanziani

Assignees

@mablanco mablanco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Post application url and commit hash as a PR comment after every deploy
2 participants
@mablanco @dublx