Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and deploy on PR #26

Closed
LucaLanziani opened this issue May 12, 2023 · 1 comment · Fixed by #58
Closed

Build and deploy on PR #26

LucaLanziani opened this issue May 12, 2023 · 1 comment · Fixed by #58
Assignees

Comments

@LucaLanziani
Copy link
Member

LucaLanziani commented May 12, 2023

As a user I would like the application to build and deploy every time a new commit is pushed to a non-draft PR.

  • the built artifact should be tagged with the branch name (format might be different if tags don't accept all characters of branches)
  • the knative service fqdm should contain the branch name as well, possibly that could be the namespace we use when deploying the service. (app-name.branch-name)
  • when the PR is merged the knative services (app-name.branch-name) should be removed, and the namespace should be deleted if that was the last service in the namespace.

Desired outcome

Write a pipeline that implements the above
Embed the pipeline in the generated binary
Persist the pipeline as part of the init command

@vinicius-marinho-nearform
Copy link
Contributor

Considering that this is a pipeline that will be used in a different environment, what should be the process of deploying? Should we use kind? Or let the client deploy and test in their own environment (maybe they have a development environment that could be used to test it, specially if they use and manage runners inside their environment)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants