New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Installation Command #46

Merged

amanvr merged 8 commits into master from feat/issue-40

May 26, 2023

Contributor

amanvr commented May 24, 2023

Closes #40

amanvr requested review from LucaLanziani, jalexander90 and zimny

May 24, 2023 09:03


          Add Installation Command

2ef1ea5

amanvr force-pushed the feat/issue-40 branch from 2bb9cf2 to 2ef1ea5 Compare

May 24, 2023 10:00


          feat(issue-40): Fix formatting for install command

025a2f7

LucaLanziani reviewed

View reviewed changes

assets/docker/Dockerfile.go.tmpl Outdated Show resolved Hide resolved

LucaLanziani reviewed

View reviewed changes

src/services/project/project.go Outdated Show resolved Hide resolved

LucaLanziani reviewed

View reviewed changes

src/services/project/project.go Outdated Show resolved Hide resolved

LucaLanziani reviewed

View reviewed changes

assets/docker/Dockerfile.go.tmpl Outdated Show resolved Hide resolved

LucaLanziani reviewed

View reviewed changes

assets/docker/Dockerfile.node.tmpl Outdated Show resolved Hide resolved

LucaLanziani previously requested changes

View reviewed changes

Member

LucaLanziani left a comment

If you accept my suggestions and write a test I'll be happy to merge the PR.

amanvr and others added 6 commits

May 24, 2023 13:40


          Update src/services/project/project.go

4a378fd

Remove Go Install Command

Co-authored-by: Luca Lanziani <luca@lanziani.com>


          Update assets/docker/Dockerfile.node.tmpl

181d02d

Add NodeInstallCommand

Co-authored-by: Luca Lanziani <luca@lanziani.com>


          Update assets/docker/Dockerfile.go.tmpl

6a3e490

Remove custom go install command

Co-authored-by: Luca Lanziani <luca@lanziani.com>


          Remove logger

32c9d21


          Add test for install command

0efd397


          Fix error message

9c32d46

amanvr requested a review from LucaLanziani

May 24, 2023 15:53

amanvr dismissed LucaLanziani’s stale review

May 25, 2023 17:07

Changes made

LucaLanziani approved these changes

View reviewed changes

amanvr merged commit 233f4bd into master

This was referenced Aug 10, 2023

chore(main): release 1.0.0 #64

Closed

chore(main): release 0.0.1 #66

Merged

simoneb deleted the feat/issue-40 branch

November 30, 2023 21:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet