Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expensive tests are broken #1156

Closed
MaksymZavershynskyi opened this issue Aug 11, 2019 · 4 comments
Closed

Expensive tests are broken #1156

MaksymZavershynskyi opened this issue Aug 11, 2019 · 4 comments
Assignees
@bowenwang1996
Labels
C-bug Category: This is a bug C-epic Category: an epic
Milestone
Outdated

Comments

@MaksymZavershynskyi
Copy link
Contributor

Our expensive tests are broken and were not run on CI.
To reproduce:

  • Checkout the most recent master/staging branch;
  • Run
  cargo test --all --features expensive_tests

Observe ~30 broken tests.

It seems like expensive tests were not run by the CI pipeline because there were configured to run daily on schedule (oppose to on each branch commit) but now the schedule was removed somehow from the Gitlab dashboard and we were not running them for a while.
@MaksymZavershynskyi MaksymZavershynskyi added C-bug Category: This is a bug C-epic Category: an epic labels Aug 11, 2019
@MaksymZavershynskyi MaksymZavershynskyi added this to the TestNet 2.1 milestone Aug 11, 2019
@MaksymZavershynskyi MaksymZavershynskyi mentioned this issue Aug 11, 2019
Merged
@MaksymZavershynskyi
Copy link
Contributor Author

Cause: contract encoded with base58 but decoded with base64

@MaksymZavershynskyi
Copy link
Contributor Author

Working branch #1157

This was referenced Aug 11, 2019
Closed
Merged
@weekly-digest weekly-digest bot mentioned this issue Aug 16, 2019
Closed
@ilblackdragon ilblackdragon removed this from the TestNet 2.1 milestone Aug 29, 2019
@ilblackdragon ilblackdragon added this to the MainNet milestone Nov 22, 2019
@MaksymZavershynskyi
Copy link
Contributor Author

@bowenwang1996 Is this fixed?

@bowenwang1996
Copy link
Collaborator

We run them in nightly tests now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bowenwang1996 bowenwang1996

Labels
C-bug Category: This is a bug C-epic Category: an epic
Projects
None yet
Milestone
Outdated
Development

No branches or pull requests
4 participants
@ilblackdragon @SkidanovAlex @bowenwang1996 @MaksymZavershynskyi