Validator reward with runtime #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| res | ||
| } | ||
| } |
There was a problem hiding this comment.
would be nice to have few a test or few.
one interesting edge case - what do we pay validators who were expected to produce 0 blocks?
There was a problem hiding this comment.
They will not get paid. There is an explicit check for this.
| let ( | ||
| last_block_hash_prev_epoch, | ||
| new_proposals, | ||
| let EpochSummary { |
There was a problem hiding this comment.
why unpack it right away, can just let epoch_summary and use epoch_summary.total_gas_used?
There was a problem hiding this comment.
Otherwise you have problems with partial moves.
bowenwang1996
force-pushed
the
validator-reward-2
branch
from
2139ecf to
9465065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make validator reward work with runtime. Re-enable all runtime tests.