Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement StateRecord for Action Receipts and Received Data #1163

Merged
merged 6 commits into from
Aug 19, 2019
Merged

Implement StateRecord for Action Receipts and Received Data #1163

merged 6 commits into from
Aug 19, 2019

Conversation

evgenykuzyakov
Copy link
Collaborator

No description provided.

MaksymZavershynskyi
MaksymZavershynskyi suggested changes Aug 14, 2019
View reviewed changes
core/store/src/lib.rs Outdated Show resolved Hide resolved
@MaksymZavershynskyi
Copy link
Contributor

I think this is in merging process, so I'll approve it assuming the merging is done correctly.

@weekly-digest weekly-digest bot mentioned this pull request Aug 16, 2019
Closed
@evgenykuzyakov
Copy link
Collaborator Author

Depends on #1170

@ilblackdragon
Copy link
Member

ilblackdragon commented Aug 17, 2019 •
edited
Loading

@evgenykuzyakov @nearmax

I've been thinking that if we add back Serialize, Deserialize implementation to the CryptoHash/PublicKey which are designed for readable serialzation and actually make a wrapper Balance(u128) and ByteArray(Vec) for args/code that has custom serialization - we can actually fully remove views. WDYT?

(Not in this PR of case)

ilblackdragon
ilblackdragon reviewed Aug 17, 2019
View reviewed changes
test-utils/state-viewer/src/main.rs
col::PENDING_DATA_COUNT => None,
col::POSTPONED_RECEIPT => {
let receipt = Receipt::try_from_slice(&value).unwrap();
Some(StateRecord::PostponedReceipt(receipt.into()))
}
_ => unreachable!(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's left? let's either remove or add explicit items here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7..255 columns. We currently, don't use enum for this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change it to enums in other PR

ilblackdragon
ilblackdragon approved these changes Aug 17, 2019
View reviewed changes
Copy link
Member

@ilblackdragon ilblackdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just couple comments.

@evgenykuzyakov evgenykuzyakov merged commit 2edba26 into staging Aug 19, 2019
@evgenykuzyakov evgenykuzyakov deleted the state-serialization-for-data branch August 19, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaksymZavershynskyi MaksymZavershynskyi MaksymZavershynskyi approved these changes

@ilblackdragon ilblackdragon ilblackdragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evgenykuzyakov @MaksymZavershynskyi @ilblackdragon