-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary serializer #1172
Binary serializer #1172
Conversation
}; | ||
} | ||
|
||
impl_for_float!(f32, u32); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should have floats at all.
impl_for_integer!(u32); | ||
impl_for_integer!(u64); | ||
impl_for_integer!(u128); | ||
impl_for_integer!(usize); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
usize is a bit unclear - as it's different on different platform.
I would actually explicitly not have usize and require cast to u32 or u64 explicitly.
Looks great, I'll merge it into my PR, so can make progress there. |
Just to keep track, bincode benches:
Will post nbor bench here. |
First stub after conversion:
|
No description provided.