Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hello.wasm project to use staging build tools and libraries #1197

Merged
merged 4 commits into from
Aug 27, 2019

Conversation

vgrichina
Copy link
Collaborator

No description provided.

@evgenykuzyakov
Copy link
Collaborator

I think the plan is to replace hello.wasm with Rust version. @nearmax

@vgrichina
Copy link
Collaborator Author

I think the plan is to replace hello.wasm with Rust version. @nearmax

this is really just to unbreak current stuff for now

it might be useful to extract some of that stuff as toolchain test for asc though even if we don't use it for other tests

@MaksymZavershynskyi
Copy link
Contributor

Is the intent to fix nearlib CI?

@vgrichina
Copy link
Collaborator Author

Is the intent to fix nearlib CI?

Intent is to make nearlib tests runnable to keep sanity, yes.

@vgrichina
Copy link
Collaborator Author

Side-effect: see impact of toolchain changes.

@MaksymZavershynskyi
Copy link
Contributor

Side-effect: see impact of toolchain changes.

You mean gulp files?

@vgrichina
Copy link
Collaborator Author

@nearmax not just gulpfiles, e.g. contract code required significant changes

@janedegtiareva
Copy link
Contributor

This now compiles on latest tools with latest runtime + compiler. Should we merge this?

@vgrichina vgrichina marked this pull request as ready for review August 27, 2019 21:28
@vgrichina vgrichina merged commit f574c10 into staging Aug 27, 2019
@bowenwang1996 bowenwang1996 deleted the staging-hello branch August 30, 2019 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants