-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package Versioning #2
Comments
Ahhh. Probably why that badge is messed up is due to the Line 3 in 7850377
This really needs to be cleaned up... |
@fishcharlie wow, you're right! That's kind of embarrassing. Usually I follow semantic versioning guidelines and use a release versioning tool like I'll fix all this right now 😃 |
@fishcharlie just updated the package version and the GitHub version 🎉 It seems that Let me know if there appear to be any problems. |
I also removed the extra dist-tags. |
Thanks for this @nebrelbug!! Amazing package you have here! |
Currently the versioning of this package is very confusing, and doesn't follow standard conventions. There are currently 3 versions of this package:
I believe I got those in order from oldest to newest, but not 100% sure (again part of the confusion).
Anyways, it's very common to do a pattern of
1.0.0-beta.x
or1.0.0-next.x
as opposed to just-x
. So not really following standards on this package.Additionally there are 2 labels for this package.
latest
andnext
.latest
is pointed to1.0.0-0
andnext
is pointed to1.0.0-2
. Butlatest
also looks to be a prerelease version (unless1.0.0-0
is not a prerelease version, which would just be even more confusing). There is no reasonlatest
should be a prerelease version. If anything you should use0.1.0
or something like that to indicate prerelease and have1.0.0
be the first stable release. All of this means that just runningnpm install npm-to-yarn
results in getting an outdated package (1.0.0-0
), I think (again trying to follow this as best as I can, but it's incredibly confusing).Also on the README it says the current version is
v1.0.0-1
. Which makes no sense at all. No idea how that is even happening, but leads to more confusion, and likely a symptom of poor versioning for this package.Finally, this leads to a lot of problems with versioning in the package.
npm
thinks the latest version is1.0.0-0
so when I runnpm outdated
it thinks I need to downgrade from1.0.0-2
to1.0.0-0
(which I don't believe is accurate).I haven't done many tests about what happens when I have
^1.0.0-2
in mypackage.json
dependencies, but I wouldn't be surprised if npm is also getting confused about that since the version doesn't follow any standard convention. I'm not confident at all that it's installing the version I want when I use^1.0.0-2
in mypackage.json
. See more: https://docs.npmjs.com/misc/semver#caret-ranges-123-025-004.Here is my proposal for how to fix this:
1.0.1
(maybe1.0.0
, but there is just a lot of confusion around1.0.0
for this package currently, so starting fresh seems like a good idea). There have been no issues ever reported on this repo (until now), and the last release was almost 3 months ago. This seems like a stable enough package to be released without a prerelease version.x.y.z-text.a
. Replacingtext
withbeta
,alpha
,next
or something similar. And replacingx.y.z
with the next semver version. Anda
with the number oftext
the version refers to. Also ensure that this is published with a tag that identical totext
.The text was updated successfully, but these errors were encountered: