-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ESM #33
Comments
@Zamiell hmm, I thought that the package was working fine with ESM. Where are you running into problems? |
@Zamiell I think that's outdated. They are using an old version of the package. |
@Zamiell you're right, they are using the current version of the package. I'll test out NodeNext resolution. |
That's incorrect. If you clone the repo, install deps, and then remove the line, you will immediately get a compiler error. |
You may have been looking at my old comment. |
I just opened #35 to fix this issue. Any feedback? If not I'll merge it and release a new version today. |
I'm not familiar enough with the intricates of ESM to double-check your work, but regardless thank you very much for the swift update! |
@Zamiell you're welcome! I just released the fix and opened a PR in the Docusaurus repo. I'll mark this as closed for now, unless further problems arise. I've tested in the Docusaurus repo and locally, though, so I don't expect that. Thanks for the feedback! |
Hello,
It appears that this package cannot be consumed by ESM projects. This is a shame, because it is relatively painless to publish libraries as dual CJS+ESM, so that they can be used by everybody. This blog goes into more detail:
https://antfu.me/posts/publish-esm-and-cjs
I propose that this package supports consumers who are using ESM.
The text was updated successfully, but these errors were encountered: