From 9aad01e22c32a92555d243c7ed56effde8e0c800 Mon Sep 17 00:00:00 2001
From: vemv <vemv@users.noreply.github.com>
Date: Mon, 13 May 2019 15:02:17 +0200
Subject: [PATCH] `defn:` prevent type hints in wrong positions

---
 src/nedap/utils/spec/impl/defn.cljc    |  5 +++++
 test/unit/nedap/utils/speced/defn.cljc | 17 ++++++++++++++++-
 2 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/src/nedap/utils/spec/impl/defn.cljc b/src/nedap/utils/spec/impl/defn.cljc
index e2c7ddd..8f5601f 100644
--- a/src/nedap/utils/spec/impl/defn.cljc
+++ b/src/nedap/utils/spec/impl/defn.cljc
@@ -59,6 +59,11 @@
         tail (if (-> tail first list?)
                tail
                (list tail))]
+    (assert (->> tail
+                 (map meta)
+                 (mapcat keys)
+                 (not-any? #{:tag}))
+            ":tag metadata placed in a wrong position.")
     {:tails              (fntails name tail)
      :docstring-and-meta docstring-and-meta}))
 
diff --git a/test/unit/nedap/utils/speced/defn.cljc b/test/unit/nedap/utils/speced/defn.cljc
index ff009e8..9586f7b 100644
--- a/test/unit/nedap/utils/speced/defn.cljc
+++ b/test/unit/nedap/utils/speced/defn.cljc
@@ -6,6 +6,7 @@
   In practice, that is completely optional and you are free to use 2, 1, or 0 return value hints in any position of your choice."
   (:require
    #?(:clj [clojure.spec.alpha :as spec] :cljs [cljs.spec.alpha :as spec])
+   [clojure.string :as string]
    #?(:clj [clojure.test :refer [deftest testing are is use-fixtures]] :cljs [cljs.test :refer-macros [deftest testing is are] :refer [use-fixtures]])
    [nedap.utils.speced :as sut]
    [unit.nedap.test-helpers :refer [every-and-at-least-one?]]))
@@ -489,4 +490,18 @@
                     #'type-hinted-metadata-n
                     #'type-hinted-metadata-n-alt
                     #'inline-function-n
-                    #'inline-function-n-alt))))]))
+                    #'inline-function-n-alt))
+
+                (testing ":tag metadata placed in wrong positions is guarded against"
+                  (are [desc input] (testing desc
+                                      (testing input
+                                        (try
+                                          (eval input)
+                                          false
+                                          (catch Exception e
+                                            true))))
+
+                    "Hinting an arity"
+                    '(sut/defn faulty
+                       ^String ([x]
+                                (-> x (* x) str)))))))]))