Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a note that TEMPLATE_DEBUG must be enabled. #17

Closed
charettes opened this issue Nov 13, 2015 · 8 comments
Closed

Add a note that TEMPLATE_DEBUG must be enabled. #17

charettes opened this issue Nov 13, 2015 · 8 comments

Comments

@charettes
Copy link
Contributor

I had to read the source to figure out it was required. Fixing the TODO would also be nice.
@nedbat
Copy link
Owner

nedbat commented Nov 15, 2015

Even better, I'd like to add an automated warning message if TEMPLATE_DEBUG is not set.

@audreyfeldroy
Copy link

Just fyi, as of Django 1.8, TEMPLATE_DEBUG is deprecated: https://docs.djangoproject.com/en/1.8/ref/settings/#template-debug

@charettes
Copy link
Contributor Author

It has been replaced by the 'debug' option in the OPTIONS of a DjangoTemplates backend.

@nedbat
Copy link
Owner

nedbat commented Dec 6, 2015

This is handled in 99ba553

@nedbat nedbat closed this as completed Dec 6, 2015
@charettes
Copy link
Contributor Author

Thanks Ned!

@jonashaag
Copy link

Will you cut a a release with this fix soon? I spent almost an hour debugging this.

@nedbat
Copy link
Owner

nedbat commented Jan 17, 2016

Version 1.2 is on PyPI now, with this fix. Sorry for the delay :)

@jonashaag
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@charettes @nedbat @audreyfeldroy @jonashaag