Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template debug should default to DEBUG #27

Closed
knyghty opened this issue Jul 24, 2016 · 4 comments
Closed

template debug should default to DEBUG #27

knyghty opened this issue Jul 24, 2016 · 4 comments

Comments

@knyghty
Copy link

knyghty commented Jul 24, 2016

Per docs it should default to DEBUG. I'm not sure if this is django's fault that it isn't explicitly set somehow, or the plugin's fault that it assumes False.

In any case, if I'm not mistaken, it can be fixed by changing:
if not template_settings.get('OPTIONS', {}).get('debug', False)
to:
if not template_settings.get('OPTIONS', {}).get('debug', settings.DEBUG)

If DEBUG happens to not be in the user's settings file, settings.DEBUG defaults to False, which seems sensible to me.

@PamelaM
Copy link
Collaborator

PamelaM commented Jan 17, 2017

@knyghty Please retry with plugin version 1.4. The plugin now lets Django parse the settings and just checks the result for DJ versions 1.8+

@PamelaM
Copy link
Collaborator

PamelaM commented Jan 26, 2017

@knyghty I hope that the latest version (1.4.1) addresses your issue. If there are no problems reported by Feb 1st, we'll consider this issue closed.

@knyghty
Copy link
Author

knyghty commented Jan 26, 2017

@PamelaM, I'm not able to test this at the moment but looking at your fix it looks like it should fix the problem, so please go ahead and close it now if you like.

@PamelaM
Copy link
Collaborator

PamelaM commented Jan 26, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants