Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Causes ng-click to break in Safari #18

Open
geoidesic opened this issue Oct 27, 2016 · 3 comments
Open

Causes ng-click to break in Safari #18

geoidesic opened this issue Oct 27, 2016 · 3 comments

Comments

@geoidesic
Copy link

This directive causes strange behaviour with buttons in Safari.
This was discovered macbooks running Yosemite and El Capitaine.

The issue is that if you do a quick full-click on a a track-pad, the ripple effect triggers but the ng-click does not.

If you perform a tap-click on the trackpad (with that feature enabled) then it works fine.
Also if you do a full-click and hold it for a moment then release it also works fine.

@fagionato
Copy link

It's also happening with me! @geoidesic any news / workaround regarding this issue? Thanks!

@geoidesic
Copy link
Author

None unfortunately. We abandoned the attempt. I'd be interested if anyone finds a solution.

@thSteve
Copy link

thSteve commented Aug 17, 2017

I fixed this by changing mousedown back to mouseup.

This change was made due to this #14

Now the mouse click event only fires if you hold it down long enough for the transition to end. It happens with both mouse and trackpad in my testing. You can test this by simply adding onclick="alert()" in the demo.

Not sure what the browser bug is that causes this but I don't think it's intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants