Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node network type validation before insert to nodes. #53

Closed
AnthonyLaw opened this issue Mar 26, 2021 · 3 comments · Fixed by #54
Closed

Add node network type validation before insert to nodes. #53

AnthonyLaw opened this issue Mar 26, 2021 · 3 comments · Fixed by #54
Assignees
@AnthonyLaw
Labels
P3 Issue Aesthetic type defect or minor code refactoring

Comments

@AnthonyLaw
Copy link
Member

AnthonyLaw commented Mar 26, 2021 •
edited
Loading

Don't know why The mainnet node information mixed into Testnet.

It may cause by node/peers endpoint.
@AnthonyLaw AnthonyLaw added the P3 Issue Aesthetic type defect or minor code refactoring label Mar 26, 2021
@AnthonyLaw AnthonyLaw self-assigned this Mar 26, 2021
AnthonyLaw added a commit that referenced this issue Mar 26, 2021
@AnthonyLaw
fixes #53
a5bdee4
@AnthonyLaw AnthonyLaw mentioned this issue Mar 26, 2021
Merged
AnthonyLaw added a commit that referenced this issue Mar 26, 2021
@AnthonyLaw
fixes #53
1b44ce7
AnthonyLaw added a commit that referenced this issue Mar 26, 2021
@AnthonyLaw
fixed #53 with added host info in error message
78fd195
@AnthonyLaw AnthonyLaw linked a pull request Mar 26, 2021 that will close this issue
fixes #53 #54
Merged
@OlegMakarenko
Copy link
Contributor

@AnthonyLaw which nodes affected non-NGL?

@AnthonyLaw
Copy link
Member Author

no sure which node, not able to detect. I did a screenshot previously.
now not able to verify.

Screenshot 2021-03-25 at 5 05 07 PM

@AnthonyLaw
Copy link
Member Author

https://nem2.slack.com/archives/C9E7N7H1N/p1616536079042500 for more dicuscss

AnthonyLaw added a commit that referenced this issue Apr 1, 2021
@AnthonyLaw
Merge pull request #54 from nemgrouplimited/validation-node
166eac9 
fixes #53
@OlegMakarenko OlegMakarenko mentioned this issue May 17, 2021
Merged
fboucquez pushed a commit that referenced this issue Oct 31, 2021
@AnthonyLaw @fboucquez
fixed #53 with added host info in error message
2f6a797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnthonyLaw AnthonyLaw

Labels
P3 Issue Aesthetic type defect or minor code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #53 symbol/statistics-service
2 participants
@AnthonyLaw @OlegMakarenko