Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the result of 'getnep5transfers' #344

Closed
hactrox opened this issue Sep 11, 2020 · 0 comments · Fixed by #345
Closed

Optimize the result of 'getnep5transfers' #344

hactrox opened this issue Sep 11, 2020 · 0 comments · Fixed by #345

Comments

@hactrox
Copy link

hactrox commented Sep 11, 2020

Summary or problem description
For GAS Claim transfers, from is null. If we call getapplicationlog, we can see from is null, which is correct, but if we call getnep5transfers, the transferaddress field is NKuyBkoGdZZSLyPbJEetheRhMjeznFZszf, not empty string, which was converted from uint160 0x0000000000000000000000000000000000000000.
This is kind of weird, if we accept this 'rule', users will find this 'address' sends a lot of gas to different addresses, but itself has zero balance.

Here is the result from applicationlog rpc call:

{
    "contract": "0xde5f57d430d3dece511cf975a8d37848cb9e0525",
    "eventname": "Transfer",
    "state": {
        "type": "Array",
        "value": [
            {
                "type": "Any"
            },
            {
                "type": "ByteString",
                "value": "+0hzR/ELFjg1xJuV/AiPJfchxnI="
            },
            {
                "type": "Integer",
                "value": "100000000"
            }
        ]
    }
}

Here is the corresponding result from getnep5transfers:

{
    "timestamp": 1468595301000,
    "assethash": "0xde5f57d430d3dece511cf975a8d37848cb9e0525",
    "transferaddress": "NKuyBkoGdZZSLyPbJEetheRhMjeznFZszf",
    "amount": "100000000",
    "blockindex": 0,
    "transfernotifyindex": 0,
    "txhash": "0x46b7f2efe74a977e12600eb40b19769e0c1b13df583ee3dc1f444fb72b0c0f7e"
}

Do you have any solution you want to propose?
If from is null, set transferaddress to empty string.

Where in the software does this update applies to?

  • Plugins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant