Neo3-preview1 release checklist

[lock9]

Neo3-preview1 release checklist
Checklist of tasks required to be accomplished for neo3-preview1.
This release should be concluded by 16/08/2019 (delayed).

Mandatory issues

• Finish scoped witnesses (Scoped Witnesses #544)
• Add readonly methods to the ABI (neo3 ABI readonly methods #927)
• Limit the size of the block to 256KB (Set max block size #953)
• Update neo-cli to support scoped witnesses (Scoped Witnesses #544)
• Remove Simple Policy plugin (neo-plugins, @vncoelho)

Testing guide

• Consensus with 7 nodes
• Send neo to account
• Test auto-claimable gas
• Send gas to account
• Send neo to account using multisig
• Send neo to account using multisig
• Send gas to contract
• Send neo to contract
• Retrieve gas from contract using single signature
• Retrieve gas from contract using multisig
• Retrieve neo from contract using single signature
• Retrieve gas from contract using multisig

Postponed to preview2:

• Finish NetworkFee update (NetworkFee calculation method #840, Update policy - Add maximum witness size (in bytes) #979)
• Create a NEP-5 template (#973, @belane)
• Update neon compiler to accept read-only methods (ReadOnly methods neo-devpack-dotnet#93)
• Compile NEP-5 template
• Upload NEP-5 SmartContract example
• Test all NEP-5 SmartContract methods

Tests:

• Test Scoped witness with global witness scope
• Test Scoped witness with scripthash scope, single use
• Test Scoped witness with scripthash scope, multiple uses
• Test Scoped witness with multisig, single use
• Test Scoped witness with multisig, multiple uses

[lock9]

@neo-project/core I kindly ask you to evaluate this

[igormcoelho]

Very good idea! Congratulations

[superboyiii]

Send neo to account: It works when sending from the Genesis multisig address. It will fail when sending from a no-gas-inside address because of system fee.
Send gas to account: It doesn't work at all since VM failed execution for making transaction.
Test auto-claimable gas: It works.
Further tests aren't able to go on until these issues are solved.

[erikzhang]

It will fail when sending from a no-gas-inside address because of system fee.

This is as expected. Transfers require a fee.

[lock9]

@superboyiii do you want to add some extra tests you plan to do in here?
For instance: transfer with fee, transfer without fee, etc.
I think all free tx will be dropped in neo3, but we need to ensure that people without NEO can start using the chain (paid by 3rd party). Otherwise, all people will need an exchange account to start using neo. Definitely not good.

[shargon]

Someone is doing these tests?

[superboyiii]

@shargon Hi, Shargon, I've tried these below:
Send neo to account(work well)
Test auto-claimable gas(work well)
Send gas to account(work well)
Send neo to account using multisig(work well)
Send neo to account using multisig(work well)
Compile NEP-5 template(fail because of incomplete neon complier)
Send gas to contract(work well)
Send neo to contract(work well)
Retrieve gas from contract using single signature(work well)
Retrieve gas from contract using multisig(work well)
Retrieve neo from contract using single signature(work well)
Retrieve gas from contract using multisig(work well)

[superboyiii]

@lock9 Dute to my test result, net_fee is necessary now. No gas no tx. It's reasonable but we'd better not make net_fee as ceil() in next improvement. Also address in Neo3 should be compatible with Neo2.

[shargon]

@superboyiii Thanks for the summary!

[shargon]

It's reasonable but we'd better not make net_fee as ceil()

Could you open a issue about this?

[superboyiii]

Sure. Here. #1051

[superboyiii]

Consensus with 7 nodes works well.