From 15e712e9880b6ab2c61f6ac1cafce8b1bb9d9ccc Mon Sep 17 00:00:00 2001 From: Dmitriy Tverdiakov Date: Mon, 4 Apr 2022 15:00:26 +0100 Subject: [PATCH] Add support for `Optimization:ImplicitDefaultArguments` feature This update excludes support for `qid` optimisation. --- .../org/testkit/backend/messages/requests/GetFeatures.java | 3 ++- .../org/testkit/backend/messages/requests/StartTest.java | 6 ++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/GetFeatures.java b/testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/GetFeatures.java index 6e5b877423..f93254d072 100644 --- a/testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/GetFeatures.java +++ b/testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/GetFeatures.java @@ -66,7 +66,8 @@ public class GetFeatures implements TestkitRequest "Feature:API:Driver.IsEncrypted", "Feature:API:SSLConfig", "Detail:DefaultSecurityConfigValueEquality", - "Detail:ThrowOnMissingId" + "Detail:ThrowOnMissingId", + "Optimization:ImplicitDefaultArguments" ) ); private static final Set SYNC_FEATURES = new HashSet<>( Arrays.asList( diff --git a/testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/StartTest.java b/testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/StartTest.java index e8dd5eae43..7b40998aeb 100644 --- a/testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/StartTest.java +++ b/testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/StartTest.java @@ -61,6 +61,12 @@ public class StartTest implements TestkitRequest COMMON_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestConnectionAcquisitionTimeoutMs\\.test_should_encompass_the_handshake_time.*$", skipMessage ); COMMON_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestConnectionAcquisitionTimeoutMs\\.test_should_fail_when_acquisition_timeout_is_reached_first.*$", skipMessage ); + skipMessage = "This test needs updating to implement expected behaviour"; + COMMON_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestAuthenticationSchemes\\.test_custom_scheme_empty$", skipMessage ); + skipMessage = "Driver does not implement optimization for qid in explicit transaction"; + COMMON_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestOptimizations\\.test_uses_implicit_default_arguments$", skipMessage ); + COMMON_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestOptimizations\\.test_uses_implicit_default_arguments_multi_query$", skipMessage ); + COMMON_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestOptimizations\\.test_uses_implicit_default_arguments_multi_query_nested$", skipMessage ); ASYNC_SKIP_PATTERN_TO_REASON.putAll( COMMON_SKIP_PATTERN_TO_REASON );