Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove react-portal because react-dom has its own Portal-API #3525

Open
mhsdesign opened this issue Jun 12, 2023 · 0 comments
Open

Remove react-portal because react-dom has its own Portal-API #3525

mhsdesign opened this issue Jun 12, 2023 · 0 comments
Labels
7.3 8.3 9.0 dependencies Pull requests that update a dependency file Technical debt

Comments

@mhsdesign
Copy link
Member

mhsdesign commented Jun 12, 2023 •
edited
Loading

I then proceeded to also remove [...] react-portal from the dialog component. [...] because react-dom has its own Portal-API, so react-portal is no longer needed.

After this (removal in #3492), react-portal is only used in @neos-project/neos-ui somewhere in the Inspector implementation. Removing it there should be done in a separate PR though.

Originally posted by @grebaldi in #3492 (comment)
@grebaldi grebaldi added Technical debt dependencies Pull requests that update a dependency file 7.3 9.0 8.3 labels Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
7.3 8.3 9.0 dependencies Pull requests that update a dependency file Technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grebaldi @mhsdesign