Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Changes & News: Follow for Updates #1075

Closed
mjlbach opened this issue Jul 15, 2021 · 16 comments
Closed

Breaking Changes & News: Follow for Updates #1075

mjlbach opened this issue Jul 15, 2021 · 16 comments

Comments

@mjlbach
Copy link
Contributor

mjlbach commented Jul 15, 2021

Please follow this issue if you would like to be updated on breaking changes and news for lspconfig.

@mjlbach mjlbach added bug Something isn't working and removed bug Something isn't working labels Jul 15, 2021
@mjlbach

This comment was marked as outdated.

@mjlbach mjlbach pinned this issue Jul 15, 2021
@neovim neovim locked and limited conversation to collaborators Jul 15, 2021
@mjlbach mjlbach unpinned this issue Sep 8, 2021
@mjlbach mjlbach pinned this issue Sep 8, 2021
@mjlbach

This comment was marked as outdated.

@mjlbach

This comment was marked as outdated.

@mjlbach

This comment was marked as outdated.

@mjlbach

This comment was marked as outdated.

@mjlbach

This comment was marked as outdated.

@mjlbach

This comment was marked as outdated.

@mjlbach

This comment was marked as outdated.

@mjlbach

This comment was marked as outdated.

@clason

This comment was marked as outdated.

@mjlbach

This comment was marked as outdated.

@mjlbach

This comment was marked as outdated.

@mjlbach

This comment was marked as outdated.

@mjlbach

This comment was marked as outdated.

@mjlbach mjlbach closed this as completed Jan 7, 2022
@mjlbach

This comment was marked as outdated.

@mjlbach
Copy link
Contributor Author

mjlbach commented Apr 15, 2022

Neovim 0.7 is out today. Two major improvements are the lua autocommands and lua user_commands API. I'm planning on merging #1838 within the next week which will break backwards compatibility with Neovim < 0.7. This will be the first minor patch version update of lspconfig (we follow semantic versioning) to lspconfig 0.2.0.

There will be two breaking changes in the update.

  • Neovim 0.6 compatibility will be dropped to allow passing closures via the lua autocommands API, this dramatically simplifies the lspconfig codebase in certain parts.
  • The commands field of setup will be renamed user_commands to distinguish from the commands field that start_client takes. The new user_commands field will have a different structure, instead taking a list of tables of the form that matches vim.api.nvim_create_user_command
  user_commands = {
     {
      name = "TexlabBuild"
      command = function()
        buf_build(0)
      end,
      opts = {
         desc = "Build the current buffer",
      }
    },
  },

You can follow #1838 to know when it is merged, and leave feedback if you disagree with the change to user_commands.

I won't consider a backport branch for 0.6 compatibility, you will need to pin to lspconfig's release branch v0.1.3

Here is how you can pin with packer.nvim:

use {
    'neovim/nvim-lspconfig',
    tag = 'v0.1.3',
}

and with vim-plug:

Plug 'neovim/nvim-lspconfig', { 'tag': 'v0.1.3' }

@dundargoc dundargoc unpinned this issue Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants