"parse_build_args.py" file parser arguments are not accessible anymore in "os.environ".

[KelSolaar]

Hi,

I'm trying to update Rez from 2.16.0 to 2.28.0 and one of the first thing I noticed is my builds failing :)

We create parse_build_args.py files to support some custom build arguments with content for example as follows:

# -*- coding: utf-8 -*-
parser.add_argument(
    '--skip-code-formatting',
    action='store_true',
    help='Skips code formatting.')

and then in the build file (we use Fabric, thus fabfile.py), we do things like that:

    if not int(os.environ['__PARSE_ARG_SKIP_CODE_FORMATTING']):
        code_formatting()

Unfortunately the __PARSE_ARG_SKIP_CODE_FORMATTING is nowhere to be seen now.

Cheers,

Thomas

[instinct-vfx]

Hey Thomas,

We ran into this too. Here is my report: #587

An here is a commit fixing this. PR is coming soon (Thanks Iraklis!) https://github.com/lambdaclan/rez/commit/af81b2492d297ad3350d1988bca47de0b4dcae7c

[KelSolaar]

@instinct-vfx : Ah good to know, will follow closely the future PR!

[KelSolaar]

I made a custom build with two cherry-picked commits from @lambdaclan and it fixed the issue for me.

Would be fantastic to have a PR for that so that we don't have to deploy a custom version, nothing really bad about it but it is extra maintenance steps.

Cheers,

Thomas

[nerdvegas]

I'm keeping an eye out for this PR also. There will be another round of merges coming soon and this one's on the list. A

…

On Thu, Apr 4, 2019 at 9:25 AM Thomas Mansencal ***@***.***> wrote: I made a custom build with two cherry-picked commits from @lambdaclan <https://github.com/lambdaclan> and it fixed the issue for me. Would be fantastic to have a PR for that so that we don't have to deploy a custom version, nothing really bad about it but it is extra maintenance steps. Cheers, Thomas — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#590 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABjqSryx0E1-IogAAiHZamZt2PDVRAdNks5vdSpbgaJpZM4cZZCQ> .

[lambdaclan]

@KelSolaar @nerdvegas I have just added a PR for the issue +1 more incoming!

[nerdvegas]

I believe this is now fixed in 2.30.0, pls reopen if incorrect