Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rez overwrites root logger #977

Closed
nerdvegas opened this issue Nov 24, 2020 · 0 comments · Fixed by #978
Closed

rez overwrites root logger #977

nerdvegas opened this issue Nov 24, 2020 · 0 comments · Fixed by #978

Comments

@nerdvegas
Copy link
Contributor

Rez logging conf is applied via init.py, and root logger handles are cleared. This has caused a problem in an unrelated package using the rez package.

Logging should be setup in cli tools only, everywhere else should just use loggers created via logging.getLogger(). Rez logging is a bit of a mess and needs an overhaul, however initially and in the interests of backwards compatibility, imo the fix should just:

  • set "rez" logger to propagate=False
  • not set root logger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant