Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wiki workflow broken #994

Closed
nerdvegas opened this issue Dec 22, 2020 · 1 comment
Closed

wiki workflow broken #994

nerdvegas opened this issue Dec 22, 2020 · 1 comment

Comments

@nerdvegas
Copy link
Contributor

nerdvegas commented Dec 22, 2020

Wiki workflow doesn't properly deal with PRs/branches and fails when master isn't being merged.

  • artifact 'wiki-markdown' could get overwritten by unrelated branches (artifact scope does not appear to be local to a workflow run)
  • "Release: xxx" title link at top of sidebar is broken. It's "refs/head/master" when it should be current release version
  • always updates master branch wiki, meaning that PRs end up overwriting current wiki docs before they're merged
@nerdvegas
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant