quoting fix

[nerdvegas]

Fixes #1114

Note that Windows test is now failing and that is intended, there's a preexisting bug there that we need to fix.

Related: #1111

[davidlatwe]

Continuing #1116 (comment) here. :)

In #1116, I changed the test to match result with shlex joined input, and it passed in Windows but actually failed in other OS.

import subprocess
from shlex import join  # new in Python 3.8, just for quick testing

>>> subprocess.check_output(join(['echo', 'hey you']), shell=True, text=True).strip()
# Windows CMD
"'hey you'"
# In my WSL (Ubuntu)
'hey you'

# however..
>>> join(['echo', 'hey you'])
"echo 'hey you'"  # same result for both platform

So maybe we should match the result with actual shell output plus shlex joined input ? Like

def popen(args, shell=False):
    process = subprocess.Popen(
        args, stdin=subprocess.PIPE, stdout=subprocess.PIPE,
        stderr=subprocess.PIPE, universal_newlines=True, shell=shell
    )
    sh_out = process.communicate()
    return sh_out[0].strip()

a = popen([rez_env_exec, "--", "echo", txt])
b = popen(shlex_join(["echo", txt]), shell=True)

self.assertEqual(a, b)

Kind of stupid but seems fair ?

Just for proving the concept, I have updated my branch and CI testing passed in both Ubuntu and Windows.

[nerdvegas]

I dunno, that seems oddly circular... all we're really doing at that point is verifying that rez-env is running the given command in a shell. Also isn't there no guarantee that the current shell (ie whatr raw subprocess will use if shell=True) will match the shell rez is using?

I'm starting to think we simply need a cmd caveat here.

[davidlatwe]

Yeah.. :(
Or, how about just validate the test cases with hard coded results ? Like..

    @per_available_shell()
    @install_dependent()
    def test_rez_env_output(self):

        cases = {
            "hey": {},
            "hey you": {"cmd": '"hey you"'},
            ...
        }

        def _test(txt):
            ...
            expect = cases[txt].get(config.default_shell, txt)
            self.assertEqual(sh_out[0].strip(), expect)

        _test("hey")  # simple case
        _test("hey you")  # with a space