Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add package filter tests, fix 1237 #1238

Merged
merged 3 commits into from
Mar 19, 2022
Merged

add package filter tests, fix 1237 #1238

merged 3 commits into from
Mar 19, 2022

Conversation

nerdvegas
Copy link
Contributor

fixes #1237

@nerdvegas nerdvegas changed the title add package filter tests add package filter tests, fix 1237 Mar 1, 2022
@JeanChristopheMorinPerso
Copy link
Member

@nerdvegas that's great! Though I notice that the RegexRule and the TimestampRule classes seem to be completely uncovered. Should a test for each be added?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nerdvegas nerdvegas merged commit 08e9715 into master Mar 19, 2022
@bpabel bpabel deleted the issue_1237-ts-filter branch January 19, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanChristopheMorinPerso JeanChristopheMorinPerso JeanChristopheMorinPerso approved these changes

@instinct-vfx instinct-vfx Awaiting requested review from instinct-vfx

@bfloch bfloch Awaiting requested review from bfloch

@maxnbk maxnbk Awaiting requested review from maxnbk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rez-test breaks with packages that do not have a timestamp attribute
2 participants
@nerdvegas @JeanChristopheMorinPerso