Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Use "QtCompat" to handle "QHeaderView" incompatibilities and fix broken "resolve" button in "rez-gui". #851

Merged
merged 4 commits into from
Feb 11, 2020

Conversation

KelSolaar
Copy link
Contributor

This PR addresses #849 by leveraging the vendored Qt.QtCompat module.

The branch is based on the https://github.com/KelSolaar/rez/tree/feature/python3 branch that is waiting to be merged in #850 (and should be merged first).

@KelSolaar KelSolaar changed the title PR: Use "QtCompat" to handle "QHeaderView" incompatibilities. PR: Use "QtCompat" to handle "QHeaderView" incompatibilities and fix broken "resolve" button in "rez-gui". Feb 6, 2020
@KelSolaar
Copy link
Contributor Author

KelSolaar commented Feb 6, 2020

This PR also fixes the broken resolve button problem reported in #852.

There are still a few late exceptions being raised but it mostly work:

Traceback (most recent call last):
  File "c:\progra~1\rez\lib\site-packages\rezgui\widgets\ViewGraphButton.py", line 46, in _contextChanged
    self.action_1.setEnabled(enable_resolve)
RuntimeError: Internal C++ object (PySide2.QtWidgets.QAction) already deleted.
Traceback (most recent call last):
  File "c:\progra~1\rez\lib\site-packages\rezgui\widgets\ViewGraphButton.py", line 46, in _contextChanged
    self.action_1.setEnabled(enable_resolve)
RuntimeError: Internal C++ object (PySide2.QtWidgets.QAction) already deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants