Issue 994 wiki workflow fixes #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 22, 2020 14:29
-set "Release:" title to rez version and correct link
|
Fixes #994 |
| @@ -1,11 +1,10 @@ | |||
| name: Wiki | |||
| on: | |||
| push: | |||
| branches: | |||
| - master | |||
There was a problem hiding this comment.
@nerdvegas This will limit us to see if the wiki builds correctly after changes to it. What we could do is allow all branches, but only run the publish step if the current branch is master. What do you think?
|
Hey JC, I did consider that, however from my own experience I'd say that
the wiki build never really fails, but instead generates problematic source
(but valid markdown) that can only be validated by actually looking at it.
And since you can't actually see it, there doesn't seem much point!
In any case if there's good reason then yes we could run the wiki build
regardless. If the artifact is still required (to somehow validate locally,
for eg) we could still do that too, but it'd have to be qualified (perhaps
with commit sha) to avoid potential overwrite across branches.
A
…On Tue, Dec 22, 2020 at 2:58 PM Jean-Christophe Morin < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/wiki.yaml
<#995 (comment)>:
> @@ -1,11 +1,10 @@
name: Wiki
on:
push:
+ branches:
+ - master
@nerdvegas <https://github.com/nerdvegas> This will limit us to see if
the wiki builds correctly after changes to it. What we could do is allow
all branches, but only run the publish step if the current branch is
master. What do you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#995 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMOUSUXKNUM5RHHY2ZXRILSWAKNTANCNFSM4VFB47YA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR limits the workflow to master merges only. It would be possible to have it work for any branch, but would involve tracking a matching remote branch in the rez.wiki project. However, that is hard (or not possible?) to see in the github UI anyway and therefore of very limited value.