Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an invalid signing key does not return an error #1410

Open
coop opened this issue Jul 17, 2024 · 1 comment
Open

Adding an invalid signing key does not return an error #1410

coop opened this issue Jul 17, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers UI/UX

Comments

@coop
Copy link
Contributor

coop commented Jul 17, 2024

https://nerveshub.com/org/my-org/settings/keys/new

Name: devkey
Key: $ cat ~/Downloads/devkey.priv | pbcopy

I mistakenly copy pasted the private key into the public key box and instead of an error the UI resets to an empty form.

It would be good to show some kind of an error that an incorrect key was added.

NOTE: I saw this behaviour on the public beta of nerves cloud.

@joshk
Copy link
Collaborator

joshk commented Jul 18, 2024

I found the error in Sentry which was caused by this.

We don't have a validation on the key length, so adding a validation is step one.

The next step might be to do some check to confirm it is a valid public key (maybe a simple format check?)

@joshk joshk added bug Something isn't working good first issue Good for newcomers UI/UX labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers UI/UX
Projects
None yet
Development

No branches or pull requests

2 participants