Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent deployment transactions which destroy type_id #13

Open
jjyr opened this issue Sep 3, 2020 · 2 comments
Open

Prevent deployment transactions which destroy type_id #13

jjyr opened this issue Sep 3, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@jjyr
Copy link
Collaborator

jjyr commented Sep 3, 2020

We need to check the deployment transactions before sent them; make sure there no type_id be destroyed. If a user intended to destroy type_id of a cell, the user must explicitly pass the type_id in the command line.

@jjyr jjyr added the enhancement New feature or request label Sep 3, 2020
@TheWaWaR
Copy link
Contributor

It seems there is no possible destroy a type_id cell?

if let Some(input_cell) = pre_inputs_cells
.iter()
.find(|(name, _cell)| name == &cell.name)
.map(|(_name, input_cell)| input_cell.clone())
{
input_cells.push(input_cell);
}

@jjyr
Copy link
Collaborator Author

jjyr commented Apr 13, 2021

Because once we lost the type ID, we have no way to resume it, this issue just suggests to add another mechainism to protect this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants