Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not remove TLC from channel state even if valid RemoveTlc message from peer received #30

Closed
contrun opened this issue May 28, 2024 · 1 comment
Closed

Should not remove TLC from channel state even if valid RemoveTlc message from peer received #30

contrun opened this issue May 28, 2024 · 1 comment

Comments

@contrun
Copy link
Collaborator

contrun commented May 28, 2024

Say tlc tlc represents an request of user_a sending some money to user_b on the condition of user_b revealing some preimage preimage_x to the hash hash_y. We can only remove tlc from channel state we are sure this tlc is included in a new commitment transaction. Otherwise, the following case can happen. If (for whatever reason) user_b refuses to send a new commitment transaction partial signature to user_a, then user_a can't take back the money because we have removed the tlc from our state, so we don't know how to take back the money even after tlc expiry.
@contrun contrun mentioned this issue May 28, 2024
Merged
@contrun contrun mentioned this issue Jun 7, 2024
Closed
@contrun
Copy link
Collaborator Author

contrun commented Jun 19, 2024

Done in #72

@contrun contrun closed this as completed Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@contrun