Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directives to be reflected in the generated schema definition file #1997

Closed
1 task done
raulburigo opened this issue Feb 9, 2022 · 1 comment
Closed
1 task done
Labels

Comments

@raulburigo
Copy link

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

As it is today, and really well documented, "Directives applied through the @directive() decorator will not be reflected in the generated schema definition file."

I know this is at topic long discussed before, but I talked to people who faced the same issue and had to work some weird solutions or even changed to schema-first approach to avoid this. So I would like to raise it again.

https://github.com/raulburigo/subgraph

Describe the solution you'd like

It would be really helpfull if the generated schema file reflected the directives applied through the @Directives()

Teachability, documentation, adoption, migration strategy

No response

What is the motivation / use case for changing the behavior?

The main problem for us today is that we are trying to use Rover CLI to manage our federated schemas, and the missing Directives prevents us to do it. We managed to get the schema with the directives after the creation of the app (example in the repo), but I don't think this is the best solution.

@kamilmysliwiec
Copy link
Member

We're tracking this here #1780

@nestjs nestjs locked and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants