Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch scheduling backend to Croner #1164

Closed
1 task done
Hexagon opened this issue Feb 12, 2023 · 2 comments
Closed
1 task done

Switch scheduling backend to Croner #1164

Hexagon opened this issue Feb 12, 2023 · 2 comments

Comments

@Hexagon
Copy link

Hexagon commented Feb 12, 2023

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

NPM package cron is broken in many ways, which you can read about here. It doesn't receive much (if any) attention. Have a look at their list of issues.

Describe the solution you'd like

I would recommend you to consider switching from npm package cron to croner.

Teachability, documentation, adoption, migration strategy

I noticed that you have implemented one feature of cron, which isn't supported by croner - the utcOffset. I could implement that if you're interested and think it is a useful feature. So far i've avoided giving that option, as time zones can have different utc offset at different time of year.

What is the motivation / use case for changing the behavior?

Croner is actively maintained, trusted by pm2, and have 0 active issues.

@Hexagon
Copy link
Author

Hexagon commented Feb 12, 2023

"Finished" a draft pull reqest, question about the importance of utcOffset remains.

@kamilmysliwiec
Copy link
Member

Let's track this here #1165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants