Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Netbox v4.1.0 support #565

Closed
mattieserver opened this issue Sep 6, 2024 · 1 comment · Fixed by #567
Closed

Netbox v4.1.0 support #565

mattieserver opened this issue Sep 6, 2024 · 1 comment · Fixed by #567
Assignees
@mattieserver
Labels
type: feature Request for new feature or change to existing feature

Comments

@mattieserver
Copy link
Collaborator

NetBox version

v4.1.0

Topology Views version

v4.1.0

Feature type

Change to existing functionality

Proposed functionality

Netbox v4.1.0 support

Use case

Netbox v4.1.0 support

External dependencies

No response
@mattieserver mattieserver added the type: feature Request for new feature or change to existing feature label Sep 6, 2024
@mattieserver mattieserver self-assigned this Sep 6, 2024
This was referenced Sep 6, 2024
Closed
Closed
@dreng
Copy link
Collaborator

dreng commented Sep 11, 2024

I played around with various options for a couple of hours and it seems that renaming get_full_name to full_name is sufficient. This is exactly what @ibuclaw suggested.

netbox-topology-views/netbox_topology_views/views.py

Line 149 in f8c6e9e

dev_name = device.device_type.get_full_name

@mattieserver mattieserver linked a pull request Sep 11, 2024 that will close this issue
fix name of devices #567
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattieserver mattieserver

Labels
type: feature Request for new feature or change to existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix name of devices netbox-community/netbox-topology-views
2 participants
@mattieserver @dreng