Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New interface type SFP (100 Base-FX) #16781

Closed
rcalpha opened this issue Jul 1, 2024 · 6 comments · Fixed by #17615
Closed

New interface type SFP (100 Base-FX) #16781

rcalpha opened this issue Jul 1, 2024 · 6 comments · Fixed by #17615
Assignees
Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@rcalpha
Copy link

rcalpha commented Jul 1, 2024

NetBox version

v4.0.6

Feature type

Data model extension

Proposed functionality

Add 100Mbps SFP interface type (100 Base FX)

Use case

I'm documenting an active network device that we have: Alcatel 7250 SAS
Specs: https://www.starmicrowave.com/wp-content/uploads/2018/03/7250SAS_v2.pdf

I tried to create 100Mbps SFP interface but netbox only has SFP (1GE). This device has both 100Mbps and 1GB. It would be useful to differentiate

Database changes

No response

External dependencies

No response

@rcalpha rcalpha added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels Jul 1, 2024
@jeffgdotorg
Copy link
Contributor

Hi, and thanks for your interest in helping improve NetBox.

My understanding of media and connectors is not comprehensive. Before I move your issue out of triage, please confirm that you are in fact using NetBox v4.0.6 as indicated. I ask because issue #11371 already added a 100Base-FX interface type, albeit without the SFP connector type designation.

@jeffgdotorg jeffgdotorg added status: revisions needed This issue requires additional information to be actionable and removed status: needs triage This issue is awaiting triage by a maintainer labels Jul 2, 2024
@rcalpha
Copy link
Author

rcalpha commented Jul 2, 2024

Yes, I'm using Netbox v4.0.6. 100Base-FX interface type is one way if the switch was it fixed using SC, FC, ST (or another type) port... however this switch use SFP slot.

@jeffgdotorg
Copy link
Contributor

Thanks for the clarification. I'm moving your issue along to needs owner status. If you or another developer with the requisite skills and capacity wants to work it through to a PR, please say so and a maintainer will assign the issue to you.

@jeffgdotorg jeffgdotorg removed their assignment Jul 2, 2024
@jeffgdotorg jeffgdotorg added complexity: low Requires minimal effort to implement status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: revisions needed This issue requires additional information to be actionable labels Jul 2, 2024
@RobertH1993
Copy link

Hi i have created an PR for this

@jeffgdotorg
Copy link
Contributor

Hi i have created an PR for this

Issue is assigned, sorry I just spotted your comment.

@jeffgdotorg jeffgdotorg added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Jul 14, 2024
@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: accepted This issue has been accepted for implementation labels Aug 15, 2024
@alehaa
Copy link
Contributor

alehaa commented Sep 25, 2024

I volunteer for this PR.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
5 participants