Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAX_PAGE_SIZE not being enforced if "limit" query param is missing #18150

Closed
bctiemann opened this issue Dec 3, 2024 · 0 comments · Fixed by #18151
Closed

MAX_PAGE_SIZE not being enforced if "limit" query param is missing #18150

bctiemann opened this issue Dec 3, 2024 · 0 comments · Fixed by #18151
Assignees
@bctiemann
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@bctiemann
Copy link
Contributor

Deployment Type

Self-hosted

Triage priority

I volunteer to perform this work (if approved)

NetBox Version

v4.1.7

Python Version

3.10

Steps to Reproduce

Set MAX_PAGE_SIZE to a small number (such as 30) in configuration.py
Access http://127.0.0.1:8000/api/dcim/interfaces/

Expected Behavior

Results should be paginated by 30, and next and previous links should have correct limit and offset values corresponding to increments of 30

Observed Behavior

The page size defaults to PAGINATE_COUNT (default 50); and the next url has limit and offset values corresponding to 50. However if you follow that link, the results are paginated by 30, as are the next and previous urls.
@bctiemann bctiemann added type: bug A confirmed report of unexpected behavior in the application status: needs triage This issue is awaiting triage by a maintainer labels Dec 3, 2024
@bctiemann bctiemann self-assigned this Dec 3, 2024
@bctiemann bctiemann added status: accepted This issue has been accepted for implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels Dec 3, 2024
@bctiemann bctiemann mentioned this issue Dec 3, 2024
Merged
@jeremystretch jeremystretch mentioned this issue Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bctiemann bctiemann

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes: #18150 - Get pagination limit with default 0 netbox-community/netbox
1 participant
@bctiemann