Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate that 0 day changelog retention means forever #3368

Closed
jlrgraham23 opened this issue Jul 23, 2019 · 2 comments · Fixed by #3369
Closed

Indicate that 0 day changelog retention means forever #3368

jlrgraham23 opened this issue Jul 23, 2019 · 2 comments · Fixed by #3369
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@jlrgraham23
Copy link
Contributor

jlrgraham23 commented Jul 23, 2019 •
edited
Loading

Environment

  • Python version: All
  • NetBox version: 3.6.1

Proposed Functionality

Correctly indicate that a changelog retention setting of 0 days is treated as indefinite on changelog pages.

Use Case

The current templates will read "Changelog retention: 0 days" if 0 is selected for indefinite retention. This is confusing to some users. Explicitly state the meaning of 0.

Database Changes

None.

External Dependencies

None.
@jlrgraham23 jlrgraham23 mentioned this issue Jul 23, 2019
Merged
@jeremystretch
Copy link
Member

This issue has been closed as it does not conform to one of the provided templates as required by the contributing guide. If you'd like to request that your issue be re-opened, please first update the content so that it matches the appropriate template (this may require rewriting your issue entirely).

@jlrgraham23
Copy link
Contributor Author

Please re-open, restored all template content...

@jeremystretch jeremystretch reopened this Jul 30, 2019
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application labels Jul 30, 2019
jeremystretch added a commit that referenced this issue Jul 30, 2019
@jeremystretch
Changelog for #3368
a6c41e0
@jeremystretch jeremystretch mentioned this issue Aug 2, 2019
Merged
@Grokzen Grokzen mentioned this issue Oct 7, 2019
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Indicate when changelog retention configured to be forever. jlrgraham23/netbox
2 participants
@jeremystretch @jlrgraham23